GitLab

2831-Q-dark_mode_implementation

See merge request !28

issue: e/backlog#2831

* Use the appropriate loaders to make our cursor in MusicUtils
* This fixes the ordering of the songs in the play queue/playlist
  when using the "Play", "Add to queue" and "Add to playlist"
  options from the overflow menu from an album or an artist's
  detailed view to match what is actually displayed

Change-Id: I43c60583de6e0e746627cdd6a8b535e627d90ec1

* We have to cast the track number column value to an int
* This makes track numbers sort numerically (i.e. 1, 2, ..., 10, ...)
  rather than lexically (i.e. 1, 10, ..., 2, ...) in the album view
* This doesn't seem to affect all albums for whatever reason:
  albums with m4a tracks seem to be sorted wrong whereas ones
  with opus tracks are seemingly fine even without this change
* The root cause here is that the TRACK column seems to be a string,
  but not one that is padded to a fixed length to allow lexical sorting.
  Note that this appears to be contrary to the documentation at:
  https://developer.android.com/reference/android/provider/MediaStore.Audio.AudioColumns#TRACK
  which says that the column is stored with FIELD_TYPE_INTEGER

Change-Id: I0bb1ce7a45b42ba58e7aab26d17572f9a71b6ff8

Change-Id: I195616cdbe81b37cee0d9f78488f6f3fa73e22ca

Completed the polishing work mentioned in q

See merge request !26

Play queue ui update(v1 q)

See merge request !23

Change-Id: Iea1b90225cd82719703c653ca674fadc66832452

Use platform apis instead of SDK

See merge request !22

Change-Id: I0c04a98baffce786c3db345679fa74ad5acf9ef6

Change-Id: I691eedc2d50b1b251a6f8de2b16a1fdb1ed0421d

Newer app launchers that support gesture navigation use 'slide up from bottom'
as a gesture to go to the home screen.  Making the play queue slider larger
makes it easier to differentiate the play queue gesture from the home gesture.

Change-Id: I6fbb041f012533d0828df63017b6129df939518e

The Activity support class requires using a theme that doesn't also have
an action bar: https://developer.android.com/training/appbar/setting-up

Caused by: java.lang.IllegalStateException: This Activity already has an action bar supplied by the window decor. Do not request Window.FEATURE_SUPPORT_ACTION_BAR and set windowActionBar to false in your theme to use a Toolbar instead.
	at androidx.appcompat.app.AppCompatDelegateImpl.setSupportActionBar(AppCompatDelegateImpl.java:345)
	at androidx.appcompat.app.AppCompatActivity.setSupportActionBar(AppCompatActivity.java:130)
	at org.lineageos.eleven.ui.activities.SettingsActivity.onCreate(SettingsActivity.java:53)
	at android.app.Activity.performCreate(Activity.java:7824)
	at android.app.Activity.performCreate(Activity.java:7813)
	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1306)
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3245)
	...

Change-Id: I9ec0d295f0c0a9cb2ebd4a9a040f1e66750a35dd

I'm not sure how this ever worked, but it should probably be using _id
directly.

java.lang.IllegalArgumentException: Invalid column audio._id AS _id
	at android.os.Parcel.createException(Parcel.java:2075)
	at android.os.Parcel.readException(Parcel.java:2039)
	at android.os.Parcel.readException(Parcel.java:1987)
	at org.lineageos.eleven.IElevenService$Stub$Proxy.open(IElevenService.java:500)
	at org.lineageos.eleven.utils.MusicUtils.playAll(MusicUtils.java:917)
	at org.lineageos.eleven.adapters.DetailSongAdapter.onItemClick(DetailSongAdapter.java:110)
	at android.widget.AdapterView.performItemClick(AdapterView.java:330)
	at android.widget.AbsListView.performItemClick(AbsListView.java:1190)
	at android.widget.AbsListView$PerformClick.run(AbsListView.java:3198)
	at android.widget.AbsListView$3.run(AbsListView.java:4116)
	at android.os.Handler.handleCallback(Handler.java:883)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loop(Looper.java:214)
	at android.app.ActivityThread.main(ActivityThread.java:7356)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:491)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:940)

Change-Id: I7f48c7e2f6f906d3c14aa28b9fd41ac8a892dec2

The derived media databases use multiple explicit names for the columns that
contain unique ids from their parent table, not a single _id column.  This
change explicitly selects the album unique id when loading an album.

Caused by: java.lang.IllegalArgumentException: Invalid column _id
	at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:170)
	at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:140)
	at android.content.ContentProviderProxy.query(ContentProviderNative.java:423)
	at android.content.ContentResolver.query(ContentResolver.java:944)
	at android.content.ContentResolver.query(ContentResolver.java:880)
	at android.content.ContentResolver.query(ContentResolver.java:836)
	at org.lineageos.eleven.loaders.AlbumLoader.makeAlbumCursor(AlbumLoader.java:150)
	at org.lineageos.eleven.loaders.AlbumLoader.loadInBackground(AlbumLoader.java:76)
	at org.lineageos.eleven.loaders.AlbumLoader.loadInBackground(AlbumLoader.java:41)
	...

Change-Id: Id2bffacb97413228a4f8871132206503900a2a83

The exception below occurs when the _id field from the media database is
read as an integer instead of a long.  The call stack above this function
correctly returns long values.

Caused by: java.lang.UnsupportedOperationException: Unknown or unsupported URL: content://media/external/audio/artists/-1755600233/albums
	at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:174)
	at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:142)
	at android.content.ContentProviderProxy.query(ContentProviderNative.java:472)
	at android.content.ContentResolver.query(ContentResolver.java:1183)
	at android.content.ContentResolver.query(ContentResolver.java:1115)
	at android.content.ContentResolver.query(ContentResolver.java:1071)
	at org.lineageos.eleven.loaders.AlbumLoader.makeAlbumCursor(AlbumLoader.java:150)
	at org.lineageos.eleven.loaders.AlbumLoader.loadInBackground(AlbumLoader.java:76)
	at org.lineageos.eleven.loaders.AlbumLoader.loadInBackground(AlbumLoader.java:41)
	at androidx.loader.content.AsyncTaskLoader.onLoadInBackground(AsyncTaskLoader.java:307)
	at androidx.loader.content.AsyncTaskLoader$LoadTask.doInBackground(AsyncTaskLoader.java:60)
	at androidx.loader.content.AsyncTaskLoader$LoadTask.doInBackground(AsyncTaskLoader.java:48)
	at androidx.loader.content.ModernAsyncTask$2.call(ModernAsyncTask.java:141)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)

Change-Id: If2250f119136744be0f28718c85f67c3b9c64327

This code is unused for years and right now Last.fm doesn't even allow
retrieving artwork through their API (for reference read:
https://getsatisfaction.com/lastfm/topics/api-announcement-dac8oefw5vrxq)

Change-Id: Iaf5faaa9bc54e3f8ad90d07fded40ba85337de05

Fixes: Specifies both LOCAL_SDK_VERSION (system_current) and
LOCAL_PRIVATE_PLATFORM_APIS (true) but should specify only one.

Change-Id: I1d37f7408cbe73f4bc9e7c278c7a58f72dc8e1f0

Change-Id: I29e3daa518e7ac993a06673e8ec4946eb3c6a187

E theme eleven for q

See merge request !21

Change-Id: Ifff0ec1c455029b60e694b5af5ed5bcc7537b8d7

Change-Id: I1b0a51bafb96426d3d4f78f13569be185ef25c4c

Change-Id: Ifa05f46a0c16ba4b7c89736e351b72b15c7a52cc

Change-Id: I5da32fe1caef559ff304e72d12cf4f407ce8b815

* `int notificationId = hashCode();` returns different
  value every time updateNotification() is called
  thus it'd end up creating multiple notifications.

Change-Id: I36b3db279f58d5e9ea6ab8846db70eb0ae820e7a