Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1e005a84 authored by Michael W's avatar Michael W
Browse files

Eleven: More fixes and warnings 

* onActivityCreated is deprecated
* PendingIntent needs mutability-flag
* Add contentDescriptions
* Make more variables final
* LruCache: There is plenty of dead code, remove that
* Remove more unused imports
* Remove CacheListeners, they are unused

Change-Id: I48359b17571baf227f9c520a0f62968b03cbd230
parent 4ff689fd

AndroidManifest.xml

+4 −2
Original line number Diff line number Diff line
@@ -44,13 +44,15 @@ 
    <!-- Lower or raise the music based on the phone state -->

    <uses-permission android:name="android.permission.READ_PHONE_STATE" />

    <!-- Used to set the devices's ringtone -->

    <uses-permission android:name="android.permission.WRITE_SETTINGS" />

    <uses-permission android:name="android.permission.WRITE_SETTINGS"

        tools:ignore="ProtectedPermissions" />

    <!-- Used to create launcher shortcuts -->

    <uses-permission android:name="com.android.launcher.permission.INSTALL_SHORTCUT" />

    <!-- Allows Eleven to read from External Storage -->

    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>

    <!-- Allows Eleven to modify media files on external storage -->

    <uses-permission android:name="android.permission.WRITE_MEDIA_STORAGE" />

    <uses-permission android:name="android.permission.WRITE_MEDIA_STORAGE"

        tools:ignore="ProtectedPermissions" />



    <!-- Audio Visualizer Permissions -->

    <uses-permission android:name="android.permission.RECORD_AUDIO" />

res/layout/activity_audio_preview.xml

+6 −5
Original line number Diff line number Diff line
@@ -74,16 +74,17 @@ 
                android:layout_height="wrap_content"

                android:layout_alignParentEnd="true"

                android:layout_alignParentTop="true"

                android:src="@drawable/btn_preview_play"/>

                android:src="@drawable/btn_preview_play"

                android:contentDescription="@null" />



            <TextView

                android:id="@+id/tv_title"

                android:layout_width="match_parent"

                android:layout_height="wrap_content"

                android:layout_alignParentLeft="true"

                android:layout_alignParentStart="true"

                android:layout_alignParentTop="true"

                android:gravity="top"

                android:layout_toLeftOf="@id/ib_playpause"

                android:layout_toStartOf="@id/ib_playpause"

                android:ellipsize="end"

                android:textSize="@dimen/preview_title_textSize"

                android:textStyle="bold"/>
@@ -92,9 +93,9 @@ 
                android:id="@+id/tv_artist"

                android:layout_width="match_parent"

                android:layout_height="wrap_content"

                android:layout_alignParentLeft="true"

                android:layout_alignParentStart="true"

                android:layout_below="@id/tv_title"

                android:layout_toLeftOf="@id/ib_playpause"

                android:layout_toStartOf="@id/ib_playpause"

                android:ellipsize="end"

                android:textSize="@dimen/preview_artist_textSize"

                android:textStyle="italic"/>

res/layout/activity_base.xml

+6 −3
Original line number Diff line number Diff line
@@ -82,7 +82,8 @@ 
                class="org.lineageos.eleven.ui.fragments.AudioPlayerFragment"

                android:layout_width="match_parent"

                android:layout_height="0dp"

                android:layout_weight="1" />

                android:layout_weight="1"

                tools:ignore="FragmentTagUsage" />

        </LinearLayout>



        <LinearLayout
@@ -101,7 +102,8 @@ 
                    android:layout_height="@dimen/sliding_panel_indicator_height"

                    android:layout_gravity="center_horizontal"

                    android:scaleType="centerInside"

                    android:src="@drawable/drag_indicator" />

                    android:src="@drawable/drag_indicator"

                    android:contentDescription="@null" />



                <include

                    android:id="@+id/secondHeaderBar"
@@ -113,7 +115,8 @@ 
                class="org.lineageos.eleven.ui.fragments.QueueFragment"

                android:layout_width="match_parent"

                android:layout_height="0dp"

                android:layout_weight="1" />

                android:layout_weight="1"

                tools:ignore="FragmentTagUsage" />

        </LinearLayout>

    </org.lineageos.eleven.slidinguppanel.SlidingUpPanelLayout>

</org.lineageos.eleven.slidinguppanel.SlidingUpPanelLayout>

res/layout/activity_settings.xml

+3 −1
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ 
<LinearLayout

    xmlns:android="http://schemas.android.com/apk/res/android"

    xmlns:app="http://schemas.android.com/apk/res-auto"

    xmlns:tools="http://schemas.android.com/tools"

    android:layout_width="match_parent"

    android:layout_height="match_parent"

    android:orientation="vertical">
@@ -36,6 +37,7 @@ 
        android:name="org.lineageos.eleven.ui.activities.SettingsActivity$SettingsFragment"

        android:layout_width="match_parent"

        android:layout_height="match_parent"

        android:tag="org.lineageos.eleven.ui.activities.SettingsActivity$SettingsFragment" />

        android:tag="org.lineageos.eleven.ui.activities.SettingsActivity$SettingsFragment"

        tools:ignore="FragmentTagUsage" />



</LinearLayout>

res/layout/album_scrim_image.xml

+2 −1
Original line number Diff line number Diff line
@@ -24,7 +24,8 @@ 
        android:id="@+id/albumImage"

        android:layout_width="match_parent"

        android:layout_height="match_parent"

        android:scaleType="centerCrop"/>

        android:scaleType="centerCrop"

        android:contentDescription="@null" />

    <LinearLayout

        android:id="@+id/albumScrim"

        android:layout_width="match_parent"