Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
A
android_packages_apps_Updater
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Merge Requests 5
    • Merge Requests 5
  • Requirements
    • Requirements
    • List
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Commits
  • e
  • os
  • android_packages_apps_Updater
  • Merge Requests
  • !36

Merged
Opened Mar 23, 2021 by Aayush Gupta@theimpulsonMaintainer5 of 10 tasks completed5/10 tasks

[Q] Address backlogs related to Updater

  • Overview 6
  • Commits 5
  • Changes 8

Description

This MR:

  • Changes the string which is responsible to show Show changelog in the menu action buttons to Show release notes
  • Enables updates auto-deletion preference by default

Related issues

  • e/backlog#2596 (closed)
  • e/backlog#2593 (closed)
  • e/backlog#1218 (closed)
  • e/backlog#2772
  • e/backlog#1079 (closed)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Related MRs

None

How has this been tested?

Clean flash a new build with this MR. Notice that:

  • Menu now shows Show release notes in place of Show changelog
  • The switch to autodelete updates once installed is now checked by default

Clean flash an old build (0.14 preferable). Build an app of Updater with this patch and push it into the system using adb. Notice that:

  • Updater now shows the proper version name in the notification, update list and install screen during an update.
  • Run the following commands and notice that Updater shows "New Updates Notification":
    • adb root
    • adb shell am broadcast -a android.intent.action.BOOT_COMPLETED -c android.intent.category.DEFAULT -n org.lineageos.updater/.UpdatesCheckReceiver

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Edited Mar 30, 2021 by Aayush Gupta
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: e/os/android_packages_apps_Updater!36
Source branch: aayush_test

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.