Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d5496fc5 authored by BO41's avatar BO41 Committed by Marten Gajda
Browse files

automated code inspect (#700) 

javadoc fixes and more
parent 5f4e9012

opentasks-provider/src/main/java/org/dmfs/provider/tasks/FTSDatabaseHelper.java

+0 −2
Original line number Original line Diff line number Diff line
@@ -399,8 +399,6 @@ public class FTSDatabaseHelper 
     *         The row id of the task.

     *         The row id of the task.

     * @param propertyId

     * @param propertyId

     *         The row id of the property.

     *         The row id of the property.

     * @param The

     *         entry type of the relation (title, description, property).

     */

     */

    private static void insertNGramRelations(SQLiteDatabase db, Set<Long> ngramIds, long taskId, Long propertyId, int contentType)

    private static void insertNGramRelations(SQLiteDatabase db, Set<Long> ngramIds, long taskId, Long propertyId, int contentType)

    {

    {

opentasks-provider/src/main/java/org/dmfs/provider/tasks/SQLiteContentProvider.java

+3 −3
Original line number Original line Diff line number Diff line
@@ -142,7 +142,7 @@ abstract class SQLiteContentProvider extends ContentProvider 
    @Override

    @Override

    public Uri insert(Uri uri, ContentValues values)

    public Uri insert(Uri uri, ContentValues values)

    {

    {

        Uri result = null;

        Uri result;

        boolean callerIsSyncAdapter = isCallerSyncAdapter(uri);

        boolean callerIsSyncAdapter = isCallerSyncAdapter(uri);

        boolean applyingBatch = applyingBatch();

        boolean applyingBatch = applyingBatch();

        SQLiteDatabase db = mOpenHelper.getWritableDatabase();

        SQLiteDatabase db = mOpenHelper.getWritableDatabase();
@@ -198,7 +198,7 @@ abstract class SQLiteContentProvider extends ContentProvider 
    @Override

    @Override

    public int update(Uri uri, ContentValues values, String selection, String[] selectionArgs)

    public int update(Uri uri, ContentValues values, String selection, String[] selectionArgs)

    {

    {

        int count = 0;

        int count;

        boolean callerIsSyncAdapter = isCallerSyncAdapter(uri);

        boolean callerIsSyncAdapter = isCallerSyncAdapter(uri);

        boolean applyingBatch = applyingBatch();

        boolean applyingBatch = applyingBatch();

        SQLiteDatabase db = mOpenHelper.getWritableDatabase();

        SQLiteDatabase db = mOpenHelper.getWritableDatabase();
@@ -229,7 +229,7 @@ abstract class SQLiteContentProvider extends ContentProvider 
    @Override

    @Override

    public int delete(Uri uri, String selection, String[] selectionArgs)

    public int delete(Uri uri, String selection, String[] selectionArgs)

    {

    {

        int count = 0;

        int count;

        boolean callerIsSyncAdapter = isCallerSyncAdapter(uri);

        boolean callerIsSyncAdapter = isCallerSyncAdapter(uri);

        boolean applyingBatch = applyingBatch();

        boolean applyingBatch = applyingBatch();

        SQLiteDatabase db = mOpenHelper.getWritableDatabase();

        SQLiteDatabase db = mOpenHelper.getWritableDatabase();

opentasks-provider/src/main/java/org/dmfs/provider/tasks/TaskProvider.java

+2 −2
Original line number Original line Diff line number Diff line
@@ -875,8 +875,8 @@ public final class TaskProvider extends SQLiteContentProvider implements OnAccou 
    @Override

    @Override

    public Uri insertInTransaction(final SQLiteDatabase db, Uri uri, final ContentValues values, final boolean isSyncAdapter)

    public Uri insertInTransaction(final SQLiteDatabase db, Uri uri, final ContentValues values, final boolean isSyncAdapter)

    {

    {

        long rowId = 0;

        long rowId;

        Uri result_uri = null;

        Uri result_uri;





        String accountName = getAccountName(uri);

        String accountName = getAccountName(uri);

        String accountType = getAccountType(uri);

        String accountType = getAccountType(uri);

opentasks-provider/src/main/java/org/dmfs/provider/tasks/handler/RelationHandler.java

+3 −3
Original line number Original line Diff line number Diff line
@@ -248,13 +248,13 @@ public class RelationHandler extends PropertyHandler 
                db.update(TaskDatabaseHelper.Tables.TASKS, taskValues, Tasks._ID + "=" + oldValues.getLong(relIdCol), null);

                db.update(TaskDatabaseHelper.Tables.TASKS, taskValues, Tasks._ID + "=" + oldValues.getLong(relIdCol), null);

            }

            }

        }

        }

        else if (type == Relation.RELTYPE_SIBLING)

        // else if (type == Relation.RELTYPE_SIBLING)

        {

        // {

            /*

            /*

             * This was a link to a sibling, since it's no longer our sibling either it or we're orphaned now We won't know unless we check all relations.

             * This was a link to a sibling, since it's no longer our sibling either it or we're orphaned now We won't know unless we check all relations.

             *

             *

             * FIXME: properly handle this case

             * FIXME: properly handle this case

             */

             */

        }

        // }

    }

    }

}
 
}

opentasks/lint.xml

+1 −1
Original line number Original line Diff line number Diff line 
<?xml version="1.0" encoding="utf-8"?>

<?xml version="1.0" encoding="utf-8"?>

<lint></lint>
 
<lint/>
 
 No newline at end of file
 
 No newline at end of file