Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5f4e9012 authored by BO41's avatar BO41 Committed by Marten Gajda
Browse files

automated code inspect (#698) 

* android lint (accessibility - performance)
* Keyboard inaccessible widget
* ScrollView size
* Use apply() on SharedPreferences
* Obsolete layout params
* android lint (security - code style)
* showAsAction=ifRoom
* code style issues
parent 822ac39b

opentasks-provider/src/main/java/org/dmfs/provider/tasks/TaskDatabaseHelper.java

+1 −1
Original line number Original line Diff line number Diff line
@@ -527,7 +527,7 @@ public class TaskDatabaseHelper extends SQLiteOpenHelper 
     *

     *

     * @return An SQL command string.

     * @return An SQL command string.

     */

     */

    public final static String createIndexString(String table, boolean unique, String... fields)

    public static String createIndexString(String table, boolean unique, String... fields)

    {

    {

        if (fields == null || fields.length < 1)

        if (fields == null || fields.length < 1)

        {

        {

opentasks/src/main/AndroidManifest.xml

+2 −1
Original line number Original line Diff line number Diff line
@@ -204,7 +204,8 @@ 
        </receiver>

        </receiver>





        <!-- custom alarm receivers -->

        <!-- custom alarm receivers -->

        <receiver android:name="org.dmfs.tasks.notification.AlarmBroadcastReceiver">

        <receiver android:name="org.dmfs.tasks.notification.AlarmBroadcastReceiver"

                android:permission="">

            <intent-filter>

            <intent-filter>

                <action android:name="org.dmfs.android.tasks.TASK_DUE"/>

                <action android:name="org.dmfs.android.tasks.TASK_DUE"/>

opentasks/src/main/java/org/dmfs/tasks/notification/TaskNotificationHandler.java

+2 −2
Original line number Original line Diff line number Diff line
@@ -150,7 +150,7 @@ public class TaskNotificationHandler extends BroadcastReceiver 
            }

            }

        }

        }

        Editor editor = PreferenceManager.getDefaultSharedPreferences(context).edit();

        Editor editor = PreferenceManager.getDefaultSharedPreferences(context).edit();

        editor.putString(SHARED_PREFERENCE_KEY_PINNED_TASKS, sb.toString()).commit();

        editor.putString(SHARED_PREFERENCE_KEY_PINNED_TASKS, sb.toString()).apply();

    }

    }
@@ -165,7 +165,7 @@ public class TaskNotificationHandler extends BroadcastReceiver 
        String pinnedTasks = PreferenceManager.getDefaultSharedPreferences(context).getString(SHARED_PREFERENCE_KEY_PINNED_TASKS, null);

        String pinnedTasks = PreferenceManager.getDefaultSharedPreferences(context).getString(SHARED_PREFERENCE_KEY_PINNED_TASKS, null);

        pinnedTasks += ",," + (pinnedTask.getUri().toString());

        pinnedTasks += ",," + (pinnedTask.getUri().toString());

        Editor editor = PreferenceManager.getDefaultSharedPreferences(context).edit();

        Editor editor = PreferenceManager.getDefaultSharedPreferences(context).edit();

        editor.putString(SHARED_PREFERENCE_KEY_PINNED_TASKS, pinnedTasks).commit();

        editor.putString(SHARED_PREFERENCE_KEY_PINNED_TASKS, pinnedTasks).apply();

    }

    }

opentasks/src/main/res/layout/activity_manage_task_list.xml

+4 −2
Original line number Original line Diff line number Diff line
@@ -17,7 +17,8 @@ 
            android:paddingEnd="16dp"

            android:paddingEnd="16dp"

            android:paddingLeft="16dp"

            android:paddingLeft="16dp"

            android:paddingRight="16dp"

            android:paddingRight="16dp"

            android:paddingStart="16dp">

            android:paddingStart="16dp"

            android:focusable="true">





        <TextView

        <TextView

                style="@style/TextAppearance.AppCompat.Subhead"

                style="@style/TextAppearance.AppCompat.Subhead"
@@ -44,7 +45,8 @@ 
            android:paddingEnd="16dp"

            android:paddingEnd="16dp"

            android:paddingLeft="16dp"

            android:paddingLeft="16dp"

            android:paddingRight="16dp"

            android:paddingRight="16dp"

            android:paddingStart="16dp">

            android:paddingStart="16dp"

            android:focusable="true">





        <TextView

        <TextView

                style="@style/TextAppearance.AppCompat.Subhead"

                style="@style/TextAppearance.AppCompat.Subhead"

opentasks/src/main/res/layout/checklist_field_view.xml

+2 −1
Original line number Original line Diff line number Diff line
@@ -28,7 +28,8 @@ 
                android:layout_marginLeft="-8dp"

                android:layout_marginLeft="-8dp"

                android:clickable="true"

                android:clickable="true"

                android:gravity="center_vertical"

                android:gravity="center_vertical"

                android:orientation="horizontal">

                android:orientation="horizontal"

                android:focusable="true">





            <ImageView

            <ImageView

                    android:id="@+id/drag_handle"

                    android:id="@+id/drag_handle"