Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Do not throw exception

Jonathan Klee requested to merge 747-r-do-not-throw-exception into master

Description

An unknown exception was thrown by GPlayApi when we were looking for split modules and no modules were found. This made AppLounge crash completely.

Technical details

Throwing an exception does not really make sense here. Returning an empty list is enough for the caller to understand there is no module found.

Tests

I could only do non-regression tests since we don't have any scenario for the crash.

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/747

10 commandments of code reviews

👪 ❤️ https://gitlab.e.foundation/internal/wiki/-/wikis/development/code-review ~

Edited by Jonathan Klee

Merge request reports

Loading