Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

fix: hide apps from search and other places when they are not visible

Fahim M. Choudhury requested to merge 3143-hide-unidisplayable-apps-from-search into main

Description

Improved application visibility on search results and other screens.

Screenshots

Finding TikTok on App Lounge from India.

Before After
tiktok-problem-india.mp4 tiktok-solution-india.mp4

Technical details

  • Uses GPlayAPI's WebDetailsHelper to find app details without providing user's authentication information.
  • Reverts a few changes from the commit, df2ac320.

Tests

In India, TikTok is not available on Google Play. In the problematic version of App Lounge, TikTok appears on the home screen and in search results.

With the fix applied, TikTok will not appear on the home screen and search results.

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/3143

10 commandments of code reviews

👪 ❤️ https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Edited by Fahim M. Choudhury

Merge request reports