GitLab

- Kotlin Android Extensions is deprecated
- It has important advantages over using findViewById

Ref:
- [1]: https://developer.android.com/topic/libraries/view-binding/migration
- [2]: https://developer.android.com/topic/libraries/view-binding#findviewbyid

Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Kotlin Android Extensions is deprecated
- It has important advantages over using findViewById

Ref:
- [1]: https://developer.android.com/topic/libraries/view-binding/migration
- [2]: https://developer.android.com/topic/libraries/view-binding#findviewbyid

Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Kotlin Android Extensions is deprecated
- It has important advantages over using findViewById

Ref:
- [1]: https://developer.android.com/topic/libraries/view-binding/migration
- [2]: https://developer.android.com/topic/libraries/view-binding#findviewbyid

Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Kotlin Android Extensions is deprecated
- It has important advantages over using findViewById

Ref:
- [1]: https://developer.android.com/topic/libraries/view-binding/migration
- [2]: https://developer.android.com/topic/libraries/view-binding#findviewbyid

Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Kotlin Android Extensions is deprecated
- It has important advantages over using findViewById

Ref:
- [1]: https://developer.android.com/topic/libraries/view-binding/migration
- [2]: https://developer.android.com/topic/libraries/view-binding#findviewbyid

Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Kotlin Android Extensions is deprecated
- It has important advantages over using findViewById

Ref:
- [1]: https://developer.android.com/topic/libraries/view-binding/migration
- [2]: https://developer.android.com/topic/libraries/view-binding#findviewbyid

Signed-off-by: Aayush Gupta <theimpulson@e.email>

Signed-off-by: Aayush Gupta <theimpulson@e.email>

Signed-off-by: Aayush Gupta <theimpulson@e.email>

Current method has been deprecated

References:
- [1]: https://developer.android.com/reference/android/os/Environment#getExternalStorageDirectory()

Signed-off-by: Aayush Gupta <theimpulson@e.email>

Signed-off-by: Aayush Gupta <theimpulson@e.email>

Observed several warnings in compilation otherwise
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Warnings observed during compilation

w: /builds/e/apps/apps/app/src/main/java/foundation/e/apps/application/model/Application.kt: (98, 29): Variable 'error' initializer is redundant
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Warnings observed in Android Studio

w: /builds/e/apps/apps/app/src/main/java/foundation/e/apps/application/model/StateManager.kt: (46, 86): Elvis operator (?:) always returns the left operand of non-nullable type String
w: /builds/e/apps/apps/app/src/main/java/foundation/e/apps/application/model/StateManager.kt: (79, 82): Elvis operator (?:) always returns the left operand of non-nullable type String
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Current method has been deprecated

w: /builds/e/apps/apps/app/src/main/java/foundation/e/apps/utils/Common.kt: (47, 53): 'getter for activeNetworkInfo: NetworkInfo!' is deprecated. Deprecated in Java
w: /builds/e/apps/apps/app/src/main/java/foundation/e/apps/utils/Common.kt: (48, 63): 'getter for isConnected: Boolean' is deprecated. Deprecated in Java
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Resolves multiple compile-time warnings
Signed-off-by: Aayush Gupta <theimpulson@e.email>

Current method has been deprecated

References:
- [1]: https://developer.android.com/reference/android/graphics/drawable/Drawable#setColorFilter(int,%20android.graphics.PorterDuff.Mode)0

Signed-off-by: Aayush Gupta <theimpulson@e.email>

w: /builds/e/apps/apps/app/src/main/java/foundation/e/apps/XAPK/InstallSplitApksActivity.kt: (83, 20): Unnecessary non-null assertion (!!) on a non-null receiver of type PackageInstaller.Session
Signed-off-by: Aayush Gupta <theimpulson@e.email>

We have migrated to require API making these checks useless
Signed-off-by: Aayush Gupta <theimpulson@e.email>

Above if-else conditional already handles all cases making this boolean is unreachable

w: /builds/e/apps/apps/app/src/main/java/foundation/e/apps/application/model/Application.kt: (202, 9): Unreachable code
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Current method has been deprecated and alternative is limited to API 28

References:
- [1]: https://developer.android.com/reference/android/content/pm/PackageInfo#versionCode
- [2]: https://developer.android.com/reference/androidx/core/content/pm/PackageInfoCompat#getLongVersionCode(android.content.pm.PackageInfo)

Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Compile-time warnings observed

w: /builds/e/apps/apps/app/src/main/java/foundation/e/apps/XAPK/XApkInstallUtils.kt: (144, 22): Unsafe use of a nullable receiver of type File?
w: /builds/e/apps/apps/app/src/main/java/foundation/e/apps/XAPK/XApkInstallUtils.kt: (145, 21): Unsafe use of a nullable receiver of type File?
Signed-off-by: Aayush Gupta <theimpulson@e.email>

Currently used method has been deprecated

References:
- [1]: https://developer.android.com/reference/android/net/NetworkInfo

Signed-off-by: Aayush Gupta <theimpulson@e.email>

Current method has been deprecated

References:
- [1]: https://developer.android.com/reference/android/content/res/Resources#getDrawable(int)

Signed-off-by: Aayush Gupta <theimpulson@e.email>

The current one has been deprecated

References:
- [1]: https://developer.android.com/reference/android/content/res/Resources#getColor(int)

Signed-off-by: Aayush Gupta <theimpulson@e.email>

getInstance() method has been deprecated

References:
- [1]: https://developer.android.com/reference/androidx/work/WorkManager.html#getInstance()

Signed-off-by: Aayush Gupta <theimpulson@e.email>

The current one has been deprecated

References:
- [1]: https://developer.android.com/reference/kotlin/android/preference/PreferenceManager

Signed-off-by: Aayush Gupta <theimpulson@e.email>

minSdkVersion is high enough for us to drop these checks
Signed-off-by: Aayush Gupta <theimpulson@e.email>

AndroidX added new "require____()" versions of common "get___()" APIs, such as getContext/getActivity/getArguments/etc.
Rather than wrap these in something like requireNotNull(), using these APIs will allow the underlying component to try
to tell you _why_ it was null, and thus yield a better error message.
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Resolves mutiple lint errors

References:
- [1]: https://stackoverflow.com/questions/59521691/use-viewlifecycleowner-as-the-lifecycleowner

Signed-off-by: Aayush Gupta <theimpulson@e.email>

Signed-off-by: Aayush Gupta <theimpulson@e.email>

- gradle gives compile-time errors otherwise
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Fix header formatting wherever required
- Add missing copyright header as well
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Drop unused imports
- Arrange existing imports
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Resolves multiple compile-time warnings
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- ViewModelProviders.of() which was part of lifecycle-extensions has been deprecated
- Switch to latest version of lifecycle-viewmodel-ktx as dependency and migrate required
  code to use ViewModelProvider()

References:
- [1]: https://developer.android.com/jetpack/androidx/releases/lifecycle#declaring_dependencies
- [2]: https://twitter.com/ianhlake/status/1159159590476382208

Signed-off-by: Aayush Gupta <theimpulson@e.email>