GitLab

narinder Rana authored Jun 21, 2021 and Aayush Gupta committed Jul 21, 2021

The new logic uses:

- Fdroid API to verify if an application exists on it and verifies it using the signature
- Introduces a new json file to store default system applications and verifies it using their signature
- Verifies non-fdroid and non-system applications using sha1sum
Signed-off-by: Aayush Gupta <theimpulson@e.email>

Signed-off-by: Aayush Gupta <theimpulson@e.email>

Observed several warnings in compilation otherwise
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Warnings observed during compilation

w: /builds/e/apps/apps/app/src/main/java/foundation/e/apps/application/model/Application.kt: (98, 29): Variable 'error' initializer is redundant
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Warnings observed in Android Studio

w: /builds/e/apps/apps/app/src/main/java/foundation/e/apps/application/model/StateManager.kt: (46, 86): Elvis operator (?:) always returns the left operand of non-nullable type String
w: /builds/e/apps/apps/app/src/main/java/foundation/e/apps/application/model/StateManager.kt: (79, 82): Elvis operator (?:) always returns the left operand of non-nullable type String
Signed-off-by: Aayush Gupta <theimpulson@e.email>

Above if-else conditional already handles all cases making this boolean is unreachable

w: /builds/e/apps/apps/app/src/main/java/foundation/e/apps/application/model/Application.kt: (202, 9): Unreachable code
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Current method has been deprecated and alternative is limited to API 28

References:
- [1]: https://developer.android.com/reference/android/content/pm/PackageInfo#versionCode
- [2]: https://developer.android.com/reference/androidx/core/content/pm/PackageInfoCompat#getLongVersionCode(android.content.pm.PackageInfo)

Signed-off-by: Aayush Gupta <theimpulson@e.email>

The current one has been deprecated

References:
- [1]: https://developer.android.com/reference/android/content/res/Resources#getColor(int)

Signed-off-by: Aayush Gupta <theimpulson@e.email>

minSdkVersion is high enough for us to drop these checks
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- gradle gives compile-time errors otherwise
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Fix header formatting wherever required
- Add missing copyright header as well
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Drop unused imports
- Arrange existing imports
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Resolves multiple compile-time warnings
Signed-off-by: Aayush Gupta <theimpulson@e.email>