GitLab

narinder Rana authored Jun 21, 2021 and Aayush Gupta committed Jul 21, 2021

The new logic uses:

- Fdroid API to verify if an application exists on it and verifies it using the signature
- Introduces a new json file to store default system applications and verifies it using their signature
- Verifies non-fdroid and non-system applications using sha1sum
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Kotlin Android Extensions is deprecated
- It has important advantages over using findViewById

Ref:
- [1]: https://developer.android.com/topic/libraries/view-binding/migration
- [2]: https://developer.android.com/topic/libraries/view-binding#findviewbyid

Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Kotlin Android Extensions is deprecated
- It has important advantages over using findViewById

Ref:
- [1]: https://developer.android.com/topic/libraries/view-binding/migration
- [2]: https://developer.android.com/topic/libraries/view-binding#findviewbyid

Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Kotlin Android Extensions is deprecated
- It has important advantages over using findViewById

Ref:
- [1]: https://developer.android.com/topic/libraries/view-binding/migration
- [2]: https://developer.android.com/topic/libraries/view-binding#findviewbyid

Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Kotlin Android Extensions is deprecated
- It has important advantages over using findViewById

Ref:
- [1]: https://developer.android.com/topic/libraries/view-binding/migration
- [2]: https://developer.android.com/topic/libraries/view-binding#findviewbyid

Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Kotlin Android Extensions is deprecated
- It has important advantages over using findViewById

Ref:
- [1]: https://developer.android.com/topic/libraries/view-binding/migration
- [2]: https://developer.android.com/topic/libraries/view-binding#findviewbyid

Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Kotlin Android Extensions is deprecated
- It has important advantages over using findViewById

Ref:
- [1]: https://developer.android.com/topic/libraries/view-binding/migration
- [2]: https://developer.android.com/topic/libraries/view-binding#findviewbyid

Signed-off-by: Aayush Gupta <theimpulson@e.email>

Signed-off-by: Aayush Gupta <theimpulson@e.email>

Signed-off-by: Aayush Gupta <theimpulson@e.email>

Current method has been deprecated

References:
- [1]: https://developer.android.com/reference/android/os/Environment#getExternalStorageDirectory()

Signed-off-by: Aayush Gupta <theimpulson@e.email>

Signed-off-by: Aayush Gupta <theimpulson@e.email>

Observed several warnings in compilation otherwise
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Warnings observed during compilation

w: /builds/e/apps/apps/app/src/main/java/foundation/e/apps/application/model/Application.kt: (98, 29): Variable 'error' initializer is redundant
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Warnings observed in Android Studio

w: /builds/e/apps/apps/app/src/main/java/foundation/e/apps/application/model/StateManager.kt: (46, 86): Elvis operator (?:) always returns the left operand of non-nullable type String
w: /builds/e/apps/apps/app/src/main/java/foundation/e/apps/application/model/StateManager.kt: (79, 82): Elvis operator (?:) always returns the left operand of non-nullable type String
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Current method has been deprecated

w: /builds/e/apps/apps/app/src/main/java/foundation/e/apps/utils/Common.kt: (47, 53): 'getter for activeNetworkInfo: NetworkInfo!' is deprecated. Deprecated in Java
w: /builds/e/apps/apps/app/src/main/java/foundation/e/apps/utils/Common.kt: (48, 63): 'getter for isConnected: Boolean' is deprecated. Deprecated in Java
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Resolves multiple compile-time warnings
Signed-off-by: Aayush Gupta <theimpulson@e.email>

Current method has been deprecated

References:
- [1]: https://developer.android.com/reference/android/graphics/drawable/Drawable#setColorFilter(int,%20android.graphics.PorterDuff.Mode)0

Signed-off-by: Aayush Gupta <theimpulson@e.email>

w: /builds/e/apps/apps/app/src/main/java/foundation/e/apps/XAPK/InstallSplitApksActivity.kt: (83, 20): Unnecessary non-null assertion (!!) on a non-null receiver of type PackageInstaller.Session
Signed-off-by: Aayush Gupta <theimpulson@e.email>

We have migrated to require API making these checks useless
Signed-off-by: Aayush Gupta <theimpulson@e.email>

Above if-else conditional already handles all cases making this boolean is unreachable

w: /builds/e/apps/apps/app/src/main/java/foundation/e/apps/application/model/Application.kt: (202, 9): Unreachable code
Signed-off-by: Aayush Gupta <theimpulson@e.email>

- Current method has been deprecated and alternative is limited to API 28

References:
- [1]: https://developer.android.com/reference/android/content/pm/PackageInfo#versionCode
- [2]: https://developer.android.com/reference/androidx/core/content/pm/PackageInfoCompat#getLongVersionCode(android.content.pm.PackageInfo)

Signed-off-by: Aayush Gupta <theimpulson@e.email>