Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Verified Commit 69ec6d1f authored by Fahim M. Choudhury's avatar Fahim M. Choudhury
Browse files

chore(update): finalize ownership diagnostics and cleanup 

Remove remaining ownership heuristics from update decisions and keep the new logging consistent across discovery, execution, and migration.

Run a final targeted regression pass so the ownership policy is maintainable and safe to extend later.
parent a12a354c

.agent/docs/fix-app-updates-with-different-stores/task-list.md

+13 −10
Original line number Diff line number Diff line
@@ -564,23 +564,23 @@ Make the new behavior easy to maintain and hard to misuse. 
### Tasks



#### Task 6.1 - Remove ownership uses of old helper logic

- [ ] Confirm no ownership decision uses `getInstallerName()` anymore.

- [ ] Keep `getInstallerName()` only if still needed for unrelated behavior.

- [ ] If it stays, leave a warning comment above it.

- [x] Confirm no ownership decision uses `getInstallerName()` anymore.

- [x] Keep `getInstallerName()` only if still needed for unrelated behavior.

- [x] If it stays, leave a warning comment above it.



#### Task 6.2 - Finalize diagnostics

- [ ] Review all new logs for consistency.

- [ ] Make sure blocked apps are hidden from update lists, update counts, and update-all behavior.

- [ ] Make sure logs are emitted from:

- [x] Review all new logs for consistency.

- [x] Make sure blocked apps are hidden from update lists, update counts, and update-all behavior.

- [x] Make sure logs are emitted from:

  - discovery hide path

  - enqueue block path

  - execution block path

  - migration path



#### Task 6.3 - Final targeted regression pass

- [ ] Re-run all touched tests.

- [ ] Add any missing regression test discovered during implementation.

- [ ] Remove dead code or unused imports introduced by the feature work.

- [x] Re-run all touched tests.

- [x] Add any missing regression test discovered during implementation.

- [x] Remove dead code or unused imports introduced by the feature work.



### Verification
@@ -611,7 +611,10 @@ Body: 


### Iteration Notes



- Add notes here after the phase is done.

- Confirmed that `getInstallerName()` now remains only in the discovery source-classification helpers; all ownership decisions use `InstallSourceDetails` plus the centralized `UpdateEligibilityChecker`.

- Final diagnostics now cover all required paths with consistent reason-code logging: discovery hide, enqueue block, execution block, and migration success/skip/failure.

- Re-ran the full touched regression set: `AppLoungePackageManagerTest`, `UpdateEligibilityCheckerTest`, `UpdateManagerImptTest`, `InstallationEnqueuerTest`, `InstallationProcessorTest`, `UpdatesWorkerTest`, and `LegacyInstallerMigrationRunnerTest`.

- No extra cleanup was needed beyond the imports and comments already adjusted during the feature work.



## Suggested Order Of Implementation