Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f2b7bb1f authored by Jeff Sharkey's avatar Jeff Sharkey
Browse files

Force loading of safe labels in PackageInstaller.

It's too easy for code to accidentally use loadLabel() when building
strings for security sensitive contexts, so add ability for a process
to always force loading of safe strings.

Test: builds, boots
Bug: 73657770
Change-Id: I0964f39dbaee4f09c2568036060b66196f1dd782
parent 86878138
Loading
Loading
Loading
Loading
+2 −1
Original line number Diff line number Diff line
@@ -29,7 +29,8 @@

    <uses-permission android:name="android.permission.ACCESS_INSTANT_APPS" />

    <application android:label="@string/app_name"
    <application android:name=".PackageInstallerApplication"
            android:label="@string/app_name"
            android:allowBackup="false"
            android:theme="@style/DialogWhenLarge"
            android:supportsRtl="true"
+28 −0
Original line number Diff line number Diff line
/*
 * Copyright (C) 2018 The Android Open Source Project
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package com.android.packageinstaller;

import android.app.Application;
import android.content.pm.PackageItemInfo;

public class PackageInstallerApplication extends Application {
    @Override
    public void onCreate() {
        super.onCreate();
        PackageItemInfo.setForceSafeLabels(true);
    }
}