Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7a557e31 authored by Joel Galenson's avatar Joel Galenson
Browse files

Remove code that checks appop history. 

PermissionUsageFragment and PermissionControllerServiceImpl both
filter usages whose last usage is outside the specified interval and
those with an access count of zero.  The latter check always fails
when appop history is disabled, and since we are not currently showing
usage data, we can simply remove the check.

Fixes: 132638167
Test: View permissions screens with history enabled and disabled.
Change-Id: Iac72c92f508b453c453ebfd56a02baccaa43575e
parent c5c0d8ea

src/com/android/packageinstaller/permission/service/PermissionControllerServiceImpl.java

+1 −2
Original line number Diff line number Diff line
@@ -518,8 +518,7 @@ public final class PermissionControllerServiceImpl extends PermissionControllerS 
            for (int groupNum = 0; groupNum < numGroups; groupNum++) {

                GroupUsage groupUsage = appGroups.get(groupNum);



                if (groupUsage.getAccessCount() <= 0

                        || groupUsage.getLastAccessTime() < filterTimeBeginMillis) {

                if (groupUsage.getLastAccessTime() < filterTimeBeginMillis) {

                    continue;

                }

                if (!shouldShowPermission(this, groupUsage.getGroup())) {

src/com/android/packageinstaller/permission/ui/handheld/PermissionUsageFragment.java

+0 −3
Original line number Diff line number Diff line
@@ -383,9 +383,6 @@ public class PermissionUsageFragment extends SettingsWithLargeHeader implements 
                GroupUsage groupUsage = appGroups.get(groupNum);

                long lastAccessTime = groupUsage.getLastAccessTime();



                if (groupUsage.getAccessCount() <= 0) {

                    continue;

                }

                if (lastAccessTime == 0) {

                    Log.w(LOG_TAG,

                            "Unexpected access time of 0 for " + appUsage.getApp().getKey() + " "