fix: let calculator overlap toolbar when horizontal
Description
When the system display text size is too large, the result and formula are hidden "behind" the toolbar in horizontal mode. The changes we made are :
- Change the ratio formula/pad (following the figma)
- Change the size of the toolbar for landscape mode
- Shorten the margin from the pads to the formula/result
This does not solve the following problem:
- A display text and/or size too large make the numbers and symbols overflow from their box. (e/backlog#8818 (closed))
Technical details
This is a cherry-pick of A15's commit: 9b1b21ed
Already merged in !38 (merged)
Screenshots
With default settings
Before:
Before, result screen:
After:
After, result screen:
Tests
- Tested whether the toolbar could still be clicked as expected.
- Tested minimal and maximal display size (and text size).
Issues
The problem exists both in a14 and a15. This merge request handles a14 https://gitlab.e.foundation/e/backlog/-/issues/8609
The merge request for A15 can be found here: !38 (merged)
10 commandments of code review
Edited by Ivan Baheux