fix: let calculator overlap toolbar when horizontal
Description
When the system display text size is too large, the result and formula are hidden "behind" the toolbar in horizontal mode. The changes we made are :
- Change the ratio formula/pad (following the figma)
- Change the size of the toolbar for landscape mode
- Shorten the margin from the pads to the formula/result
Technical details
For the toolbar height, it was originally set to "?attr/actionBarSize" but due to the fact that we need to set it to different values in the dimens.xml files, we can't have attribute reference in them. Thus we set it to it's value (56 dip).
Another solution would have been to programmatically change the toolbar size, I tried it but it felt like too much change when a simpler solution existed.
Screenshots
Screenshots with custom colors to see the different elements.
With default settings
Before:
After:
Tests
- Tested whether the toolbar could still be clicked as expected.
Issues
The problem exists both in a14 and a15. This merge request handles a15 https://gitlab.e.foundation/e/backlog/-/issues/8609