Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2ecba24c authored by Zhijun He's avatar Zhijun He Committed by Android (Google) Code Review
Browse files

Merge "Camera2: Raw is not croppable" into lmp-preview-dev

parents 6eb03e10 9e6d1880
Loading
Loading
Loading
Loading
+5 −2
Original line number Original line Diff line number Diff line
@@ -1126,8 +1126,11 @@ public final class CaptureRequest extends CameraMetadata implements Parcelable {
     * output, cropping to a smaller region if necessary to
     * output, cropping to a smaller region if necessary to
     * maintain the stream's aspect ratio.</p>
     * maintain the stream's aspect ratio.</p>
     * <p>HAL2.x uses only (x, y, width)</p>
     * <p>HAL2.x uses only (x, y, width)</p>
     * <p>Any additional per-stream cropping must be done to
     * <p>The crop region is applied after the RAW to other color space (e.g. YUV)
     * maximize the final pixel area of the stream.</p>
     * conversion. Since raw streams (e.g. RAW16) don't have the conversion stage,
     * it is not croppable. The crop region will be ignored by raw streams.</p>
     * <p>For non-raw streams, any additional per-stream cropping will
     * be done to maximize the final pixel area of the stream.</p>
     * <p>For example, if the crop region is set to a 4:3 aspect
     * <p>For example, if the crop region is set to a 4:3 aspect
     * ratio, then 4:3 streams should use the exact crop
     * ratio, then 4:3 streams should use the exact crop
     * region. 16:9 streams should further crop vertically
     * region. 16:9 streams should further crop vertically
+5 −2
Original line number Original line Diff line number Diff line
@@ -1749,8 +1749,11 @@ public final class CaptureResult extends CameraMetadata {
     * output, cropping to a smaller region if necessary to
     * output, cropping to a smaller region if necessary to
     * maintain the stream's aspect ratio.</p>
     * maintain the stream's aspect ratio.</p>
     * <p>HAL2.x uses only (x, y, width)</p>
     * <p>HAL2.x uses only (x, y, width)</p>
     * <p>Any additional per-stream cropping must be done to
     * <p>The crop region is applied after the RAW to other color space (e.g. YUV)
     * maximize the final pixel area of the stream.</p>
     * conversion. Since raw streams (e.g. RAW16) don't have the conversion stage,
     * it is not croppable. The crop region will be ignored by raw streams.</p>
     * <p>For non-raw streams, any additional per-stream cropping will
     * be done to maximize the final pixel area of the stream.</p>
     * <p>For example, if the crop region is set to a 4:3 aspect
     * <p>For example, if the crop region is set to a 4:3 aspect
     * ratio, then 4:3 streams should use the exact crop
     * ratio, then 4:3 streams should use the exact crop
     * region. 16:9 streams should further crop vertically
     * region. 16:9 streams should further crop vertically