Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9e6d1880 authored by Zhijun He's avatar Zhijun He
Browse files

Camera2: Raw is not croppable 

Update spec doc to clarify that raw stream is not croppable.

Bug: 15168075
Change-Id: I4ffa8e2a06acd17913426ba37744bb9df1bc7330
parent fa7c755a

core/java/android/hardware/camera2/CaptureRequest.java

+5 −2
Original line number Diff line number Diff line
@@ -1126,8 +1126,11 @@ public final class CaptureRequest extends CameraMetadata implements Parcelable { 
     * output, cropping to a smaller region if necessary to

     * maintain the stream's aspect ratio.</p>

     * <p>HAL2.x uses only (x, y, width)</p>

     * <p>Any additional per-stream cropping must be done to

     * maximize the final pixel area of the stream.</p>

     * <p>The crop region is applied after the RAW to other color space (e.g. YUV)

     * conversion. Since raw streams (e.g. RAW16) don't have the conversion stage,

     * it is not croppable. The crop region will be ignored by raw streams.</p>

     * <p>For non-raw streams, any additional per-stream cropping will

     * be done to maximize the final pixel area of the stream.</p>

     * <p>For example, if the crop region is set to a 4:3 aspect

     * ratio, then 4:3 streams should use the exact crop

     * region. 16:9 streams should further crop vertically

core/java/android/hardware/camera2/CaptureResult.java

+5 −2
Original line number Diff line number Diff line
@@ -1749,8 +1749,11 @@ public final class CaptureResult extends CameraMetadata { 
     * output, cropping to a smaller region if necessary to

     * maintain the stream's aspect ratio.</p>

     * <p>HAL2.x uses only (x, y, width)</p>

     * <p>Any additional per-stream cropping must be done to

     * maximize the final pixel area of the stream.</p>

     * <p>The crop region is applied after the RAW to other color space (e.g. YUV)

     * conversion. Since raw streams (e.g. RAW16) don't have the conversion stage,

     * it is not croppable. The crop region will be ignored by raw streams.</p>

     * <p>For non-raw streams, any additional per-stream cropping will

     * be done to maximize the final pixel area of the stream.</p>

     * <p>For example, if the crop region is set to a 4:3 aspect

     * ratio, then 4:3 streams should use the exact crop

     * region. 16:9 streams should further crop vertically