Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4a6c406d authored by Jihoon Kang's avatar Jihoon Kang
Browse files

Prevent host install modules from depending on non-host required deps

Unlike image variations, host variations do not have any unique suffixes
in `LOCAL_MODULE` that can used to distinguish the variants from the
device variants. This means that the device variants and the host
variants of a module can share the same `LOCAL_MODULE` value when the
Androidmk entries are generated by Soong, and unexpectedly share the
properties, given how kati relies on `ALL_MODULES.$(module_name).*`
variables to generate the make build rules.

This becomes a problem for adding required deps, as with
I7fd55f22cb8067545c2970e65c93a25dfd762a32 `LOCAL_*_REQUIRED_MODULES` can
differ between host variants and device variants. To resolve this issue,
this change introduces a new variable to track the targets installed by
the host variants and prevent the device only required deps from being
added as dependencies to the host-installed targets.

Test: aninja -t path out/host/linux-x86/bin/mke2fs out/target/product/vsoc_x86_64/system/etc/mke2fs.conf
Bug: 413097935
Change-Id: I22c86fc62faa2b42696c211afd2c8ca6c92f5f62
parent 4fedf1f2
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment