Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Less optimistic callback invocation

Fynn Godau requested to merge 910-less-optimistic-callback into master

Description

Gas Now app initializes again. Biryani By Kilo behaves properly.

Screenshots

Technical details

  • Gas Now sets an onInitalized callback before calling our onCreate and crashes because map is still null. Therefore, never do early callback invocation before onCreate is called, i.e. while mapView is still null.
  • Biryani By Kilo is, for an unknown reason, not performing its map updates if the callback is executed before the rest of its code that immediately follows the call that sets the callback (likely: the rest of its onCreate). Therefore, delay callback invocation until after next UI draw.

Tests

Start Gas Now app.

Use Biryani By Kilo, select your location as location, see map moving to your location.

Issues

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/development/code-review

Edited by Fynn Godau

Merge request reports

Loading