Less optimistic callback invocation
Description
Gas Now app initializes again. Biryani By Kilo behaves properly.
Screenshots
Technical details
- Gas Now sets an onInitalized callback before calling our onCreate and crashes because map is still
null
. Therefore, never do early callback invocation beforeonCreate
is called, i.e. whilemapView
is stillnull
. - Biryani By Kilo is, for an unknown reason, not performing its map updates if the callback is executed before the rest of its code that immediately follows the call that sets the callback (likely: the rest of its onCreate). Therefore, delay callback invocation until after next UI draw.
Tests
Start Gas Now app.
Use Biryani By Kilo, select your location as location, see map moving to your location.
Issues
- https://gitlab.e.foundation/e/os/backlog/-/issues/910
- e/backlog#6847 (closed)
- e/backlog#6845 (closed)
10 commandments of code reviews
Edited by Fynn Godau