Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

7421-Fix_illegalArgumentException_on_refreshCollectionWorker

Description

In RefreshCollectionWorker, service Entity is pulled at the class's init state. If DB return null entity, it throws IllegalArgumnetException. As it is thrown in the init stage, not inside the doWork method, the worker is not canceled & it crashes the app. After restarting the app (event after device reboot or app version upgrade) the worker re-trigger & crash the app, again, makes the app unusable.

This worker is called right after the user logged-in. If user able to logout before the worker trigger by the OS, the above-mentioned scenario is observed.

Screenshots

Technical details

Tests

Issues

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Merge request reports

Loading