Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6fbb2f7d authored by Felipe Balbi's avatar Felipe Balbi
Browse files

usb: gadget: mv_u3d: fix sparse warnings 



fix the following sparse warnings:

drivers/usb/gadget/mv_u3d_core.c:223:20: warning: context imbalance in 'mv_u3d_done' - unexpected unlock
drivers/usb/gadget/mv_u3d_core.c:1562:25: warning: context imbalance in 'mv_u3d_handle_setup_packet' - unexpected unlock

Note that the non-trivial sparse warnings
are left out of this commit due to lack of
HW to test:

drivers/usb/gadget/mv_u3d_core.c:906:42: warning: incorrect type in argument 2 (different address spaces)
drivers/usb/gadget/mv_u3d_core.c:906:42:    expected void [noderef] <asn:2>*<noident>
drivers/usb/gadget/mv_u3d_core.c:906:42:    got unsigned int *<noident>

Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 94a06018

drivers/usb/gadget/mv_u3d_core.c

+4 −0
Original line number Original line Diff line number Diff line
@@ -186,6 +186,8 @@ static int mv_u3d_process_ep_req(struct mv_u3d *u3d, int index, 
 */

 */

static

static

void mv_u3d_done(struct mv_u3d_ep *ep, struct mv_u3d_req *req, int status)

void mv_u3d_done(struct mv_u3d_ep *ep, struct mv_u3d_req *req, int status)

	__releases(&ep->udc->lock)

	__acquires(&ep->udc->lock)

{

{

	struct mv_u3d *u3d = (struct mv_u3d *)ep->u3d;

	struct mv_u3d *u3d = (struct mv_u3d *)ep->u3d;
@@ -1520,6 +1522,8 @@ static int mv_u3d_is_set_configuration(struct usb_ctrlrequest *setup) 




static void mv_u3d_handle_setup_packet(struct mv_u3d *u3d, u8 ep_num,

static void mv_u3d_handle_setup_packet(struct mv_u3d *u3d, u8 ep_num,

	struct usb_ctrlrequest *setup)

	struct usb_ctrlrequest *setup)

	__releases(&u3c->lock)

	__acquires(&u3c->lock)

{

{

	bool delegate = false;

	bool delegate = false;