Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 94a06018 authored by Felipe Balbi's avatar Felipe Balbi
Browse files

usb: gadget: mv_udc_core: fix sparse warnings 



fix the following sparse warnings:

drivers/usb/gadget/mv_udc_core.c:1850:6: warning: symbol 'irq_process_reset' was not declared. Should it be static?
drivers/usb/gadget/mv_udc_core.c:247:9: warning: context imbalance in 'done' - unexpected unlock
drivers/usb/gadget/mv_udc_core.c:1692:25: warning: context imbalance in 'handle_setup_packet' - unexpected unlock

Note that there are still other sparse warnings
which aren't trivial to fix, so I left them out:

drivers/usb/gadget/mv_udc_core.c:848:34: warning: incorrect type in argument 1 (different address spaces)
drivers/usb/gadget/mv_udc_core.c:848:34:    expected void const volatile [noderef] <asn:2>*addr
drivers/usb/gadget/mv_udc_core.c:848:34:    got unsigned int *<noident>
drivers/usb/gadget/mv_udc_core.c:849:42: warning: incorrect type in argument 2 (different address spaces)
drivers/usb/gadget/mv_udc_core.c:849:42:    expected void volatile [noderef] <asn:2>*addr
drivers/usb/gadget/mv_udc_core.c:849:42:    got unsigned int *<noident>

Acked-by: default avatarNeil Zhang <zhangwm@marvell.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 3f8b6201

drivers/usb/gadget/mv_udc_core.c

+5 −1
Original line number Diff line number Diff line
@@ -212,6 +212,8 @@ static int process_ep_req(struct mv_udc *udc, int index, 
 * request is still in progress.

 */

static void done(struct mv_ep *ep, struct mv_req *req, int status)

	__releases(&ep->udc->lock)

	__acquires(&ep->udc->lock)

{

	struct mv_udc *udc = NULL;

	unsigned char stopped = ep->stopped;
@@ -1651,6 +1653,8 @@ static void ch9setfeature(struct mv_udc *udc, struct usb_ctrlrequest *setup) 


static void handle_setup_packet(struct mv_udc *udc, u8 ep_num,

	struct usb_ctrlrequest *setup)

	__releases(&ep->udc->lock)

	__acquires(&ep->udc->lock)

{

	bool delegate = false;
@@ -1847,7 +1851,7 @@ static void irq_process_tr_complete(struct mv_udc *udc) 
	}

}



void irq_process_reset(struct mv_udc *udc)

static void irq_process_reset(struct mv_udc *udc)

{

	u32 tmp;

	unsigned int loops;