Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e85a5c79 authored by Rodrigo Vivi's avatar Rodrigo Vivi Committed by Daniel Vetter
Browse files

Revert "drm/i915/chv: Use timeout mode for RC6 on chv" 

This reverts commit 5a0afd4b.

Although timeout mode allows higher residency it impact badly on performance.
I believe while we don't have a way to balance between performance and
power savings at runtime I believe we have to revert and prioritize
performance that was impacted a lot.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88103


Cc: Deepak S <deepak.s@linux.intel.com>
Cc: Wendy Wang <wendy.wang@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent d60de81d

drivers/gpu/drm/i915/intel_pm.c

+2 −3
Original line number Original line Diff line number Diff line
@@ -4689,8 +4689,7 @@ static void cherryview_enable_rps(struct drm_device *dev) 
		I915_WRITE(RING_MAX_IDLE(ring->mmio_base), 10);

		I915_WRITE(RING_MAX_IDLE(ring->mmio_base), 10);

	I915_WRITE(GEN6_RC_SLEEP, 0);

	I915_WRITE(GEN6_RC_SLEEP, 0);





	/* TO threshold set to 1750 us ( 0x557 * 1.28 us) */

	I915_WRITE(GEN6_RC6_THRESHOLD, 50000); /* 50/125ms per EI */

	I915_WRITE(GEN6_RC6_THRESHOLD, 0x557);





	/* allows RC6 residency counter to work */

	/* allows RC6 residency counter to work */

	I915_WRITE(VLV_COUNTER_CONTROL,

	I915_WRITE(VLV_COUNTER_CONTROL,
@@ -4704,7 +4703,7 @@ static void cherryview_enable_rps(struct drm_device *dev) 
	/* 3: Enable RC6 */

	/* 3: Enable RC6 */

	if ((intel_enable_rc6(dev) & INTEL_RC6_ENABLE) &&

	if ((intel_enable_rc6(dev) & INTEL_RC6_ENABLE) &&

						(pcbr >> VLV_PCBR_ADDR_SHIFT))

						(pcbr >> VLV_PCBR_ADDR_SHIFT))

		rc6_mode = GEN7_RC_CTL_TO_MODE;

		rc6_mode = GEN6_RC_CTL_EI_MODE(1);





	I915_WRITE(GEN6_RC_CONTROL, rc6_mode);

	I915_WRITE(GEN6_RC_CONTROL, rc6_mode);