Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 497f4896 authored by Marten Gajda's avatar Marten Gajda Committed by GitHub
Browse files

Detect state saved before FM commit, fixes #756 (#760) 

Under certain conditions the task details fragment was about to be replaced after the fragment manager already saved its state. This caused a crash. This change checks whether the state has already been saved before committing the transaction.
parent 5650c86e

opentasks/src/main/java/org/dmfs/tasks/TaskListActivity.java

+8 −3
Original line number Diff line number Diff line
@@ -455,10 +455,15 @@ public class TaskListActivity extends BaseActivity implements TaskListFragment.C 


    private void replaceTaskDetailsFragment(@NonNull Fragment fragment)

    {

        getSupportFragmentManager().beginTransaction()

        FragmentManager fragmentManager = getSupportFragmentManager();

        // only change state if the state has not been saved yet, otherwise just drop it

        if (!fragmentManager.isStateSaved())

        {

            fragmentManager.beginTransaction()

                    .setCustomAnimations(0, R.anim.openttasks_fade_exit, 0, 0)

                    .replace(R.id.task_detail_container, fragment, DETAILS_FRAGMENT_TAG).commit();

        }

    }





    private void updateTitle(int pageId)