Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8cee65ec authored by Leon Scroggins III's avatar Leon Scroggins III
Browse files

AImageDecoder: update comments around dataspaces 

Bug: 135133301
Test: I5e8bdcdae6837db23c0f4ef08f931f3bebe0ce0d

A companion change (I489f31fef79dec11e97c8e8fb9207adb77a3d0c7) makes
AImageDecoder default to doing no color conversion. Update comments to
reflect that.

Change-Id: Icc3b0f101598ce98c458ff43597ee05b3662664c
parent 7ac76eef

include/android/imagedecoder.h

+9 −9
Original line number Original line Diff line number Diff line
@@ -349,20 +349,20 @@ int AImageDecoderHeaderInfo_getAlphaFlags( 
        const AImageDecoderHeaderInfo*) __INTRODUCED_IN(30);

        const AImageDecoderHeaderInfo*) __INTRODUCED_IN(30);





/**

/**

 * Report the dataspace the {@link AImageDecoder} will decode to by default.

 * Report the dataspace the AImageDecoder will decode to by default.

 * AImageDecoder will try to choose one that is sensible for the

 * image and the system. Note that this may not exactly match the ICC

 * profile (or other color information) stored in the encoded image.

 *

 *

 * @return The {@link ADataSpace} most closely representing the way the colors

 * By default, {@link AImageDecoder_decodeImage} will not do any color

 *         are encoded (or {@link ADATASPACE_UNKNOWN} if there is not an

 * conversion.

 *         approximate ADataSpace). This specifies how to interpret the colors

 *

 * @return The {@link ADataSpace} representing the way the colors

 *         are encoded (or {@link ADATASPACE_UNKNOWN} if there is not a

 *         corresponding ADataSpace). This specifies how to interpret the colors

 *         in the decoded image, unless {@link AImageDecoder_setDataSpace} is

 *         in the decoded image, unless {@link AImageDecoder_setDataSpace} is

 *         called to decode to a different ADataSpace.

 *         called to decode to a different ADataSpace.

 *

 *

 *         Note that ADataSpace only exposes a few values. This may return

 *         Note that ADataSpace only exposes a few values. This may return

 *         ADATASPACE_UNKNOWN, even for Named ColorSpaces, if they have no

 *         {@link ADATASPACE_UNKNOWN}, even for Named ColorSpaces, if they have

 *         corresponding ADataSpace.

 *         no corresponding {@link ADataSpace}.

 */

 */

int32_t AImageDecoderHeaderInfo_getDataSpace(

int32_t AImageDecoderHeaderInfo_getDataSpace(

        const AImageDecoderHeaderInfo*) __INTRODUCED_IN(30);

        const AImageDecoderHeaderInfo*) __INTRODUCED_IN(30);