Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 47db6ebf authored by Pablo Ceballos's avatar Pablo Ceballos
Browse files

SF: Prevent accidentally re-adding a removed layer 

Bug 25887783

Change-Id: Ib13ebdfb55d40c0f2175b2bc521214a07281e69a
parent 438afe17

services/surfaceflinger/SurfaceFlinger.cpp

+2 −2
Original line number Diff line number Diff line
@@ -2241,7 +2241,7 @@ uint32_t SurfaceFlinger::setClientStateLocked( 
        if (what & layer_state_t::eLayerChanged) {

            // NOTE: index needs to be calculated before we update the state

            ssize_t idx = mCurrentState.layersSortedByZ.indexOf(layer);

            if (layer->setLayer(s.z)) {

            if (layer->setLayer(s.z) && idx >= 0) {

                mCurrentState.layersSortedByZ.removeAt(idx);

                mCurrentState.layersSortedByZ.add(layer);

                // we need traversal (state changed)
@@ -2277,7 +2277,7 @@ uint32_t SurfaceFlinger::setClientStateLocked( 
        if (what & layer_state_t::eLayerStackChanged) {

            // NOTE: index needs to be calculated before we update the state

            ssize_t idx = mCurrentState.layersSortedByZ.indexOf(layer);

            if (layer->setLayerStack(s.layerStack)) {

            if (layer->setLayerStack(s.layerStack) && idx >= 0) {

                mCurrentState.layersSortedByZ.removeAt(idx);

                mCurrentState.layersSortedByZ.add(layer);

                // we need traversal (state changed)