Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

feat: add warning message on pin/password screen

Ivan Baheux requested to merge 2738-main-forgot_password into main

Description

Following issue 2728 :

  • Added a warning message when user chooses a password/pin.
  • Added a card around the warning text
  • Added a warning icon on top of warning message
  • Added es, fr, de, it translations. With chatGPT, following advice.

Screenshots

base

Translations

French German Italian Spanish
Image 2 Image 3 Image 4 Image 5

Technical details

In androidx.compose: The "outlined" warning icon was not different from the "filled" warning icon, so we added our own outlined warning icon.

Tests

We tested both pin and password screen. We did this for every language we pushed.

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/2738

10 commandments of code reviews

👪 ❤️ https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Edited by Ivan Baheux

Merge request reports

Loading