Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

chore: Setup modules detekt, spotless, telemetry for /e/OS features

Description

Prepare ntfy project to add notifications receiver feature, in an updateable way. The idea behind this is to migrate the work done on notificationreceiver project as new modules in foundation.e.ntfy project. The clean archi used in NotificationsReceiver should allow a straightforward integration (mainly rewrite repositories and subscription process which is a different procedure now)

Pros:

  • reuse already validated work (review and functional) done in NotificationReceiver
  • minimise modifications inside ntfy codebase

Cons:

  • bigger codebase at the end (some features almost duplicated between ntfy and NotificationsReceiver)

To prepare this, the following step are implemented here:

  • add dagger / hilt
  • add sentry
  • prepare for unit testing
  • CI with lint, detekt, test, build

10 commandments of code review

👪 ❤️ https://gitlab.e.foundation/groups/e/-/wikis/contribute/development-processes/code-review-guidelines

Edited by Guillaume Jacquart

Merge request reports

Loading