Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

feat: add nc-common-glide-lib for image loading

Fahim Salam Chowdhury requested to merge 1897-Use_nc_sso_glide_lib into main

Description

Nextcloud Notes app use NC-Common-glide library to load avatar images. Previously we have to replace this library with vanilla glide library to resolve e/backlog#6839 (closed). As now, we are introducing session-cookie sharing with https://gitlab.e.foundation/e/os/backlog/-/issues/1897, reverting this change will bring performance improvement.

Screenshots

Technical details

NC-common-glide lib is written in Kotlin & NC-SSO part is in java. Glide lib is passing Kotlin.collection.emptyList when no query is passed on the URL, which is not deserializable to java.collection class. To resolve this, we have to pass dummy query value.

Tests

Issues

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Merge request reports

Loading