Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

1422-Sanitize_userId_for_ocs_request

Fahim Salam Chowdhury requested to merge 1422-Sanitize_userId_for_ocs_request into main

Description

As @e.email accounts has username same as their email, but @murena.io accounts don't have that part, in /e/OS Notes app GET https://murena.io/ocs/v2.php/cloud/users/<user-name> returns 404, because right now, it is passing the full email as userName. We need to sanitize the username to avoid 404 for murena.io accounts.

Screenshots

Technical details

Tests

Login with e.email & murena.io accounts & open /e/OS Notes app, check log, there is no exception thrown for /ocs/v2.php/cloud/users/<userId> endpoint request.

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/1422

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Merge request reports

Loading