Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Remove nc-sso-glide library

Description

Upstream uses com.github.stefan-niedermann.nextcloud-commons:sso-glide lib to load avatar images like other nc requests through nc app (in our case accountManager by default). But accountManager failed to deserialize nc request perfectly and then log out an error message, although the image loaded perfectly. As for now, only avatar images are being loaded & they are public by default, so we can remove this library & load the avatar directly via glide, so no unwanted exception is thrown.

Screenshots

Technical details

If in the future, the private image loading support is added (loading image inside note which required auth to retrieve), we might need to revert this commit.

Tests

setup account in the /e/OS Account Manager & open /e/OS Notes app, check logs for /e/OS Account Manager & /e/OS Notes app, no error is logged.

Issues

10 Commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/development/code-review

Merge request reports

Loading