Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

fix(favorites): removing places from the favorites

Description

When we add and remove an address from the favourites, it appears that it will still keep the deleted addresses still saved when you do it from the “:grey_heart:favourites” button in the navigation function (it seems it's missing a link between the newly added address and the delete button "unsave"

Screenshots

Before

after

Technical details

There is a inconsistency in place id which so when user try to remove the favourite place it not removed from the DB and so it is always showing in favourite places list. It is creating new id (using UUID) every time when user add to favourite place so there is a duplicate entries generated for the same place in favourites.

Tests

Issues

#82

10 commandments of code review

👪 ❤️ code review guidelines

Edited by Mitul Sheth

Merge request reports

Loading