Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e3409a8e authored by mitulsheth's avatar mitulsheth
Browse files

fix(ETA): Code review update

parent b7422794

cardinal-android/app/src/main/java/earth/maps/cardinal/routing/RoutingOptions.kt

+2 −3
Original line number Diff line number Diff line
@@ -104,7 +104,7 @@ data class AutoRoutingOptions( 
 * Routing options for truck mode (extends auto with truck-specific parameters).

 */

data class TruckRoutingOptions(

    override val costingType: String = COSTING_TYPE_AUTO,

    override val costingType: String = COSTING_TYPE_TRUCK,



    // Basic auto options

    override val maneuverPenalty: Double? = null,
@@ -219,8 +219,7 @@ data class CyclingRoutingOptions( 
data class PedestrianRoutingOptions(

    override val costingType: String = "pedestrian",



    // Walking speed

    val walkingSpeed: Double? = WALKING_SPEED, // km/h

    val walkingSpeed: Double? = WALKING_SPEED_IN_KMH, // km/h



    // Path preferences (factors)

    val walkwayFactor: Double? = null,

cardinal-android/app/src/main/java/earth/maps/cardinal/ui/core/AppContent.kt

+1 −1
Original line number Diff line number Diff line
@@ -1111,7 +1111,7 @@ private fun TurnByTurnRoute( 
    }



    val routingMode = runCatching {

        RoutingMode.entries.find { it.value.equals(routingModeJson, ignoreCase = true) } ?: RoutingMode.AUTO

        RoutingMode.entries.first { it.value.equals(routingModeJson, ignoreCase = true) } ?: RoutingMode.AUTO

    }.getOrElse { RoutingMode.AUTO }

cardinal-android/app/src/main/java/earth/maps/cardinal/ui/navigation/NavigationChrome.kt

+1 −0
Original line number Diff line number Diff line
@@ -206,6 +206,7 @@ class NavigationChromeViewModel @Inject constructor( 
            }

        }

    }



    override fun onCleared() {

        cleared = true

        super.onCleared()