Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 84cbd7fd authored by mitulsheth's avatar mitulsheth
Browse files

fix(code-review): This itinerary is too long 

- Resolved code review messages
parent c3b9106b

cardinal-android/app/src/main/java/earth/maps/cardinal/ui/directions/DirectionUiError.kt

+4 −4
Original line number Diff line number Diff line
@@ -24,12 +24,12 @@ sealed class DirectionUiError { 
    data class Unknown(val message: String?) : DirectionUiError()

}



object DirectionCodes {

    const val DISTANCE_EXCEEDED = "DistanceExceeded"

enum class DirectionCodes(val value: String) {

    DISTANCE_EXCEEDED("DistanceExceeded")

}



fun ParsingException.InvalidStatusCode.toRouteError(): DirectionUiError =

    when (this.code) {

        DirectionCodes.DISTANCE_EXCEEDED -> DirectionUiError.DistanceExceeded

        DirectionCodes.DISTANCE_EXCEEDED.value -> DirectionUiError.DistanceExceeded

        else -> DirectionUiError.Unknown(this.message)

    }

cardinal-android/app/src/test/java/earth/maps/cardinal/ui/directions/DirectionsViewModelTest.kt

+1 −1
Original line number Diff line number Diff line
@@ -294,7 +294,7 @@ class DirectionsViewModelTest { 
        coEvery { mockFerrostarWrapperRepository.driving } returns mockFerrostarWrapper



        val distanceExceededException = ParsingException.InvalidStatusCode(

            code = DirectionCodes.DISTANCE_EXCEEDED,

            code = DirectionCodes.DISTANCE_EXCEEDED.value,

            description = "Distance exceeded"

        )

        coEvery {