Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

4721-Crash_in_dark_mode_issue

Fahim Salam Chowdhury requested to merge 4721-Crash_in_dark_mode_issue into main

Description

On dark theme selected for os, Mail app crashed. & mail app UI has some UI issue for the dark-theme.
This MR fix the crash issue & update UI elements (styles & colors) to make it use-able for both light & dark theme.

Issue(s)

Test environment

Download & setup x86 emulator from: https://gitlab.e.foundation/e/priv/os/build/-/jobs/249215

OR,

Pipeline build:
FEATURE_BRANCH: 4721-Crash_in_dark_mode_issue

OR,

gradle run in 4721-Crash_in_dark_mode_issue branch

Test procedures

  • Set devices theme in dark-mode
  • Open Mail app
  • Navigate through the app, check all UI elements consistency & visibility

Technical details

Crash was caused style elements was missed for dark-theme in themes.xml.

Screenshots

1 2 3 4 5
screenshot_20220125_21_48_18 screenshot_20220125_21_49_45 screenshot_20220125_21_49_52 screenshot_20220125_21_50_11 screenshot_20220125_21_50_28
screenshot_20220125_21_50_34 screenshot_20220125_21_50_39 screenshot_20220125_21_51_06 screenshot_20220125_21_51_26 screenshot_20220125_21_55_44

Check list

  • Self review
  • Test procedure explained
  • Tested on fresh install
  • Tested applied as an update
  • License
  • Internal documentation
  • User documentation
Edited by Fahim Salam Chowdhury

Merge request reports

Loading