Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4bed7a59 authored by cketti's avatar cketti
Browse files

Remove unused method parameters

parent e59f57f6

app/core/src/main/java/com/fsck/k9/controller/MessagingController.java

+1 −1
Original line number Diff line number Diff line
@@ -419,7 +419,7 @@ public class MessagingController { 
            // Collecting statistics of the search result

            MessageRetrievalListener<LocalMessage> retrievalListener = new MessageRetrievalListener<LocalMessage>() {

                @Override

                public void messageFinished(LocalMessage message, int number, int ofTotal) {

                public void messageFinished(LocalMessage message) {

                    if (!isMessageSuppressed(message)) {

                        List<LocalMessage> messages = new ArrayList<>();

app/core/src/main/java/com/fsck/k9/mailstore/LocalStore.java

+2 −5
Original line number Diff line number Diff line
@@ -399,7 +399,6 @@ public class LocalStore { 
            @Override

            public Void doDbWork(final SQLiteDatabase db) {

                Cursor cursor = null;

                int i = 0;

                try {

                    cursor = db.rawQuery(queryString + " LIMIT 10", placeHolders);
@@ -409,9 +408,8 @@ public class LocalStore { 


                        messages.add(message);

                        if (listener != null) {

                            listener.messageFinished(message, i, -1);

                            listener.messageFinished(message);

                        }

                        i++;

                    }

                    cursor.close();

                    cursor = db.rawQuery(queryString + " LIMIT -1 OFFSET 10", placeHolders);
@@ -422,9 +420,8 @@ public class LocalStore { 


                        messages.add(message);

                        if (listener != null) {

                            listener.messageFinished(message, i, -1);

                            listener.messageFinished(message);

                        }

                        i++;

                    }

                } catch (Exception e) {

                    Timber.d(e, "Got an exception");

app/core/src/test/java/com/fsck/k9/controller/MessagingControllerTest.java

+1 −1
Original line number Diff line number Diff line
@@ -201,7 +201,7 @@ public class MessagingControllerTest extends K9RobolectricTest { 
        controller.searchLocalMessagesSynchronous(search, listener);



        verify(localStore).searchForMessages(messageRetrievalListenerCaptor.capture(), eq(search));

        messageRetrievalListenerCaptor.getValue().messageFinished(localMessage, 1, 1);

        messageRetrievalListenerCaptor.getValue().messageFinished(localMessage);

        verify(listener).listLocalMessagesAddMessages(eq(account),

                eq((String) null), eq(Collections.singletonList(localMessage)));

    }

backend/imap/src/main/java/com/fsck/k9/backend/imap/ImapSync.kt

+2 −2
Original line number Diff line number Diff line
@@ -483,7 +483,7 @@ internal class ImapSync( 
            unsyncedMessages,

            fetchProfile,

            object : MessageRetrievalListener<ImapMessage> {

                override fun messageFinished(message: ImapMessage, number: Int, ofTotal: Int) {

                override fun messageFinished(message: ImapMessage) {

                    try {

                        if (message.isSet(Flag.DELETED)) {

                            Timber.v(
@@ -533,7 +533,7 @@ internal class ImapSync( 
            smallMessages,

            fetchProfile,

            object : MessageRetrievalListener<ImapMessage> {

                override fun messageFinished(message: ImapMessage, number: Int, ofTotal: Int) {

                override fun messageFinished(message: ImapMessage) {

                    try {

                        // Store the updated message locally

                        backendFolder.saveMessage(message, MessageDownloadState.FULL)

backend/imap/src/test/java/com/fsck/k9/backend/imap/TestImapFolder.kt

+2 −2
Original line number Diff line number Diff line
@@ -97,7 +97,7 @@ class TestImapFolder(override val serverId: String) : ImapFolder { 
    ) {

        if (messages.isEmpty()) return



        messages.forEachIndexed { index, imapMessage ->

        for (imapMessage in messages) {

            val uid = imapMessage.uid.toLong()



            val flags = messageFlags[uid].orEmpty().toSet()
@@ -109,7 +109,7 @@ class TestImapFolder(override val serverId: String) : ImapFolder { 
            }

            imapMessage.body = storedMessage.body



            listener?.messageFinished(imapMessage, index, messages.size)

            listener?.messageFinished(imapMessage)

        }

    }