Remove unused callbacks from `MessageRetrievalListener` (e59f57f6) · Commits · e / os / Mail

app/core/src/main/java/com/fsck/k9/controller/MessagingController.java

+0 −8

Original line number	Diff line number	Diff line
		@@ -418,14 +418,6 @@ public class MessagingController {

		// Collecting statistics of the search result
		MessageRetrievalListener<LocalMessage> retrievalListener = new MessageRetrievalListener<LocalMessage>() {
		@Override
		public void messageStarted(String message, int number, int ofTotal) {
		}

		@Override
		public void messagesFinished(int number) {
		}

		@Override
		public void messageFinished(LocalMessage message, int number, int ofTotal) {
		if (!isMessageSuppressed(message)) {

+4 −6

Original line number	Diff line number	Diff line
		@@ -395,9 +395,9 @@ public class LocalStore {
		final String queryString, final String[] placeHolders
		) throws MessagingException {
		final List<LocalMessage> messages = new ArrayList<>();
		final int j = database.execute(false, new DbCallback<Integer>() {
		database.execute(false, new DbCallback<Void>() {
		@Override
		public Integer doDbWork(final SQLiteDatabase db) {
		public Void doDbWork(final SQLiteDatabase db) {
		Cursor cursor = null;
		int i = 0;
		try {
		@@ -431,12 +431,10 @@ public class LocalStore {
		} finally {
		Utility.closeQuietly(cursor);
		}
		return i;

		return null;
		}
		});
		if (listener != null) {
		listener.messagesFinished(j);
		}

		return Collections.unmodifiableList(messages);

+0 −6

Original line number	Diff line number	Diff line
		@@ -509,9 +509,6 @@ internal class ImapSync(
		Timber.e(e, "Error while storing downloaded message.")
		}
		}

		override fun messageStarted(uid: String, number: Int, ofTotal: Int) = Unit
		override fun messagesFinished(total: Int) = Unit
		},
		syncConfig.maximumAutoDownloadMessageSize
		)
		@@ -562,9 +559,6 @@ internal class ImapSync(
		Timber.e(e, "SYNC: fetch small messages")
		}
		}

		override fun messageStarted(uid: String, number: Int, ofTotal: Int) = Unit
		override fun messagesFinished(total: Int) = Unit
		},
		-1
		)

+0 −18

Original line number	Diff line number	Diff line
		@@ -447,16 +447,6 @@ class Pop3Sync {
		Timber.e(e, "Error while storing downloaded message.");
		}
		}

		@Override
		public void messageStarted(String uid, int number, int ofTotal) {
		}

		@Override
		public void messagesFinished(int total) {
		// FIXME this method is almost never invoked by various Stores! Don't rely on it unless fixed!!
		}

		},
		syncConfig.getMaximumAutoDownloadMessageSize());
		}
		@@ -503,14 +493,6 @@ class Pop3Sync {
		Timber.e(e, "SYNC: fetch small messages");
		}
		}

		@Override
		public void messageStarted(String uid, int number, int ofTotal) {
		}

		@Override
		public void messagesFinished(int total) {
		}
		},
		-1);

+0 −18

Original line number	Diff line number	Diff line
		@@ -433,16 +433,6 @@ class WebDavSync {
		Timber.e(e, "Error while storing downloaded message.");
		}
		}

		@Override
		public void messageStarted(String uid, int number, int ofTotal) {
		}

		@Override
		public void messagesFinished(int total) {
		// FIXME this method is almost never invoked by various Stores! Don't rely on it unless fixed!!
		}

		},
		syncConfig.getMaximumAutoDownloadMessageSize());
		}
		@@ -488,14 +478,6 @@ class WebDavSync {
		Timber.e(e, "SYNC: fetch small messages");
		}
		}

		@Override
		public void messageStarted(String uid, int number, int ofTotal) {
		}

		@Override
		public void messagesFinished(int total) {
		}
		},
		-1);