Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9ffeebf0 authored by Brad Ebinger's avatar Brad Ebinger
Browse files

Do not Lock on Registration and Config Query 

ImsRegistration and ImsConfig interfaces do not
need to be locked on because they access a
TelephonyManager API independent of MmTelFeature
state.

Bug: 74119196
Test: Telephony Unit Tests
Change-Id: I458db42cd815f87f57eab6b13878532105297180
parent 84f10d7b

src/java/com/android/ims/MmTelFeatureConnection.java

+6 −12
Original line number Diff line number Diff line
@@ -484,16 +484,11 @@ public class MmTelFeatureConnection { 
    }



    public IImsConfig getConfigInterface() throws RemoteException {

        synchronized (mLock) {

            checkServiceIsReady();

        return getConfig();

    }

    }



    public @ImsRegistrationImplBase.ImsRegistrationTech int getRegistrationTech()

            throws RemoteException {

        synchronized (mLock) {

            checkServiceIsReady();

        IImsRegistration registration = getRegistration();

        if (registration != null) {

                return registration.getRegistrationTechnology();
@@ -501,7 +496,6 @@ public class MmTelFeatureConnection { 
            return ImsRegistrationImplBase.REGISTRATION_TECH_NONE;

        }

    }

    }



    public IImsEcbm getEcbmInterface() throws RemoteException {

        synchronized (mLock) {