Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

refactor(GetAliasOperation): rewrite run method to use nextcloudClient

Vincent Bourgmayer requested to merge 1843-getAlias-with-ncClient into main

Description

eDrive get a resource failed to close related to getAliasOperation().

Screenshots

Technical details

The leaks looks to come from execution of get method with OwnCloudClient.

So I reimplemented the run method to let it use NextCloudClient. It is even better because OwncloudClient is deprecated within the lib (despite they still need to work to completely remove it)

Tests

I succeeded to reproduce last time with a reboot after setting a murena account. I run many sync & update trial and can't see any resource fails to close nor app crash due to strictVM policy enable on my apk.

Also, I checked within the widget that the alias are available and they're.

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/1843

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Merge request reports

Loading