Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

299 step 6 remove persistent flag

Vincent Bourgmayer requested to merge 299-step-6-remove-persistent-flag-2 into 115-epic

Description

Remove persistent flag of eDrive

Technical details

Note for QA: ADB command to trigger synchronization has changed.

adb shell am broadcast -a foundation.e.drive.action.FORCE_SYNC --receiver-include-background is replaced by adb shell am broadcast -a foundation.e.drive.action.FORCE_SCAN --receiver-include-background

  • I added a new command, that make eDrive to generate 10 empty files in Documents directory and upload them. Can be triggered as many times as wanted, because file's name is based on timestamp.

Use this command to run it: adb shell am broadcast -a foundation.e.drive.action.TEST_SYNC --receiver-include-background

README has been updated accordingly.

Tests

  • Does the app restart by itself if killed by system or crashed ? not immediately + mainly problematic for FileObserver
  • Can it close the ForegroundService of SyncWorker.kt ? yes
  • Apps works after update from previous version
  • Uploads files
  • Download files
  • Disable synchronization of removed files

Issues

https://gitlab.e.foundation/e/os/backlog/-/work_items/1752

https://gitlab.e.foundation/e/os/backlog/-/issues/299

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Edited by Vincent Bourgmayer

Merge request reports

Loading