Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

[eDrive][persisted=false] STEP 1: replace InitializerService by Receivers

Vincent Bourgmayer requested to merge 299-step-1-remove-initializerService into main

Description

When we will remove persistent flag of eDrive, background services won't run anymore. So we have to replace them with allowed component.

This MR only apply to InitializerService's removal.

/i\ This MR doesn't require to remove persistent flag

Technical details

⚠ This will require update on AccountManager, to replace the intent sent to match removed InitializerService by a broadcasted intent.

Check this MR as example

Some improvement can probably be done. I firstly thought to put most of the code of AccountAddedReceiver into a dedicated AccountSetupWorker.kt like in this MR but then I realized it was not necessary.

Contains also some variable & class renaming

Tests

Some unit test could be add for the canStart method of AccountAddedReceiver

Issues

https://gitlab.e.foundation/e/os/backlog/-/work_items/1680 https://gitlab.e.foundation/e/os/backlog/-/issues/299

10 commandments of code reviews

👪 ❤ https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Edited by Vincent Bourgmayer

Merge request reports