Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

prevent remote deletion after local deletion due to fileObserver

Vincent Bourgmayer requested to merge 921-local-file-deletion into v1-oreo

Description

Without the MR, when a file is removed on the cloud, then eDrive remove it on device. This triggered the FileEventListener (which detect deletion on device) which ask for a remote deletion request.

Same happened after a download, an Upload request where tried to send (but not executed in this particular case).

With this MR, neither the upload, neither the remote deletion request are sent anymore.

Technical details

Also prevent an NPE in SynchronizationService.OnRemoteOperationFinish()

Tests

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/921

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/development/code-review

Merge request reports

Loading