Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Implement new classes to handle listing of existing content

Vincent Bourgmayer requested to merge 762-add-FileLister-classes into v1-oreo

Description

Extract and improve code from ListFileRemoteOperation & ObserverService into dedicated classes:

  • AbstractFileLister: which contains the workflow and algorithm for listing file
  • LocalFileLister: which contains implementations of AbstractFileLister for Listing files on the device
  • RemoteFileLister: which contains implementations of AbstractFileLister for listing files from the cloud

This merge request contains also, tests classes to assert behaviour of FileListerClasses:

  • LocalFileListerTest
  • RemoteFileListerTest

Technical details

The tests uses mockito a lot.

Tests

Issues

backlog#762

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/development/code-review

Edited by Vincent Bourgmayer

Merge request reports

Loading