Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Refactor DownloadFileOperation.java

Vincent Bourgmayer requested to merge 762-refactor-DownloadFileOperation into v1-oreo

Description

small refactoring of DownloadFileOperation to :

  • prevent NPE & Security Exception
  • limit risk of corner case which could result in a file deletion after a download
  • Make code easier to read and manage

Tests

https://gitlab.e.foundation/e/os/eDrive/-/quality/test_cases/146

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/762

10 commandments of code reviews

👪 ❤ https://gitlab.e.foundation/internal/wiki/-/wikis/development/code-review

Edited by Vincent Bourgmayer

Merge request reports