Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

fix duplicate typo error in url param

tcecyk requested to merge tcecyk/docker-lineage-cicd:master into master

Description

the curl is errorenous - contains a duplicate url param "?" - the curl is defective currently and most likely returns a false on tag detection, making the script fail with the misleading "Missing "vendor/lineage", aborting" if the given tag doesn't exist as branch too

the typo originated probably from discussion with @nicofonk on my own PR, leading to changing the url to a better endpoint, but introducing the duplicate "?"

Issue(s)

Test environment

  • just using curl

Test procedures

  • run an example curl with a known to exist tag
# proper

$ curl -s https://gitlab.e.foundation/api/v4/projects/659/repository/tags?search=v1.12.3-s | jq -r ".[].name" | grep -q "v1.12.3-s"
$ echo $?
0

# faulty

$ curl -s https://gitlab.e.foundation/api/v4/projects/659/repository/tags?search?v1.12.3-s | jq -r ".[].name" | grep -q "v1.12.3-s"
$ echo $?
1

Check list

  • Self review
  • Test procedure explained
  • Tested on fresh install
  • Tested applied as an update
  • License
  • Internal documentation
  • User documentation
Edited by tcecyk

Merge request reports

Loading