Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Fix issue#2899 - background not centered

Seweryn Fornalik requested to merge Issue-2899/Fix_not_centered_background into master

Description

After recent UI changes there was some minor issue with the circled background, presented on the months related screens, that is kept centered in relation to the foreground number.

Related issues

e/backlog#2899 (closed)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Related MRs

None

How has this been tested?

This issue is device dependent and can be observed on the device with very high screen density. I tested it on my Samsung A5, but failed to spot the problem.

I've changed some /e/OS related configuration and managed to run the app on the Android emulator, on Pixel 4 XL, where I could reproduce the issue. This enabled me to analyze the problem and fix it.

In order to verify the fix run the app on a device that is known to have this issue, and choose "Month" option from a navigation drawer. Current day of month should be highlighted and centered inside circular background.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
Edited by Seweryn Fornalik

Merge request reports

Loading