Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06a825f9 authored by Mohammed Althaf T's avatar Mohammed Althaf T 😊
Browse files

Browser: disable/remove unused preferences

parent 8cdb6d36
Loading
Loading
Loading
Loading
Loading
+26 −0
Original line number Diff line number Diff line
From a177f67795435619d7c7cbfa0fda4db32773f30a Mon Sep 17 00:00:00 2001
From: fgei <fgei@gmail.com>
Date: Tue, 21 Feb 2023 02:02:40 +0000
Subject: [PATCH 1/3] Disable Play services dependent password manager feature
 by default

---
 .../password_manager/core/common/password_manager_features.cc   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/components/password_manager/core/common/password_manager_features.cc b/components/password_manager/core/common/password_manager_features.cc
index 1a65e0de5c8ec..981c7af555348 100644
--- a/components/password_manager/core/common/password_manager_features.cc
+++ b/components/password_manager/core/common/password_manager_features.cc
@@ -138,7 +138,7 @@ BASE_FEATURE(kPasswordSuggestionBottomSheetV2,
 // database will be unused but kept in sync for local passwords.
 BASE_FEATURE(kUnifiedPasswordManagerAndroid,
              "UnifiedPasswordManagerAndroid_LAUNCHED",
-             base::FEATURE_ENABLED_BY_DEFAULT);
+             base::FEATURE_DISABLED_BY_DEFAULT);
 
 // Enables use of Google Mobile services for non-sycned password storage.
 BASE_FEATURE(kUnifiedPasswordManagerLocalPasswordsAndroid,
-- 
2.34.1
+52 −0
Original line number Diff line number Diff line
From e3e119fd25fc4dc8c8fca92eac8c94345454c0e0 Mon Sep 17 00:00:00 2001
From: fgei <fgei@gmail.com>
Date: Fri, 15 Oct 2021 13:49:33 +0000
Subject: [PATCH 2/3] Browser: Remove some preferences from UI

---
 .../chrome/browser/privacy/settings/PrivacySettings.java  | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java b/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
index 65d7d279c99e7..3f414adb320b5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
@@ -165,6 +165,8 @@ public class PrivacySettings extends PreferenceFragmentCompat
         mIncognitoLockSettings = new IncognitoLockSettings(incognitoReauthPreference);
         mIncognitoLockSettings.setUpIncognitoReauthPreference(getActivity());
 
+        getPreferenceScreen().removePreference(findPreference(PREF_PRIVACY_SANDBOX));
+
         Preference safeBrowsingPreference = findPreference(PREF_SAFE_BROWSING);
         safeBrowsingPreference.setSummary(
                 SafeBrowsingSettingsFragment.getSafeBrowsingSummaryString(getContext()));
@@ -174,6 +176,8 @@ public class PrivacySettings extends PreferenceFragmentCompat
             return false;
         });
 
+        getPreferenceScreen().removePreference(findPreference(PREF_SAFE_BROWSING));
+
         setHasOptionsMenu(true);
 
         mSearchSuggestions = (ChromeSwitchPreference) findPreference(PREF_SEARCH_SUGGESTIONS);
@@ -186,6 +190,8 @@ public class PrivacySettings extends PreferenceFragmentCompat
         mContextualSearch.setSummary(
                 isContextualSearchEnabled ? R.string.text_on : R.string.text_off);
 
+        getPreferenceScreen().removePreference(findPreference(PREF_CONTEXTUAL_SEARCH));
+
         ChromeSwitchPreference canMakePaymentPref =
                 (ChromeSwitchPreference) findPreference(PREF_CAN_MAKE_PAYMENT);
         canMakePaymentPref.setOnPreferenceChangeListener(this);
@@ -222,6 +228,8 @@ public class PrivacySettings extends PreferenceFragmentCompat
         Preference syncAndServicesLink = findPreference(PREF_SYNC_AND_SERVICES_LINK);
         syncAndServicesLink.setSummary(buildSyncAndServicesLink());
 
+        getPreferenceScreen().removePreference(findPreference(PREF_SYNC_AND_SERVICES_LINK));
+
         // set up history expire days threshold preference
         List<TimeFrequencySpinnerOption> options = new ArrayList<>();
         options.add(new TimeFrequencySpinnerOption(0,
-- 
2.34.1
+28 −0
Original line number Diff line number Diff line
From 495928e16a716a16d297d72f94b2d3551fe10a55 Mon Sep 17 00:00:00 2001
From: althafvly <althafvly@gmail.com>
Date: Fri, 6 Oct 2023 11:14:46 +0530
Subject: [PATCH 3/3] Browser: Disable dev options in any build by default

---
 .../chrome/browser/tracing/settings/DeveloperSettings.java    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tracing/settings/DeveloperSettings.java b/chrome/android/java/src/org/chromium/chrome/browser/tracing/settings/DeveloperSettings.java
index 2aea7f1bfbb84..4d390aa3ac4b5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tracing/settings/DeveloperSettings.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tracing/settings/DeveloperSettings.java
@@ -31,9 +31,9 @@ public class DeveloperSettings extends PreferenceFragmentCompat {
     public static boolean shouldShowDeveloperSettings() {
         // Always enabled on canary, dev and local builds, otherwise can be enabled by tapping the
         // Chrome version in Settings>About multiple times.
-        if (sIsEnabledForTests != null) return sIsEnabledForTests;
+        // if (sIsEnabledForTests != null) return sIsEnabledForTests;
 
-        if (VersionConstants.CHANNEL <= Channel.DEV) return true;
+        // if (VersionConstants.CHANNEL <= Channel.DEV) return true;
         return SharedPreferencesManager.getInstance().readBoolean(
                 ChromePreferenceKeys.SETTINGS_DEVELOPER_ENABLED, false);
     }
-- 
2.34.1
+4 −0
Original line number Diff line number Diff line
@@ -52,3 +52,7 @@
0033-Browser-Disable-Android-native-autofill-by-default.patch
0034-Browser-Enable-unified-autoplay-by-default.patch
0035-Change-accent-and-switch-to-match-our-palette.patch

0001-Disable-Play-services-dependent-password-manager-fea.patch
0002-Browser-Remove-some-preferences-from-UI.patch
0003-Browser-Disable-dev-options-in-any-build-by-default.patch