Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

fix(update): rebind Update All button on recreated views

Description

Update All button in Updates screen wouldn't accept click on it when you navigate to other screens, come back to it and click the button. It would only respond if the app sources were changed in the Settings screen.

This MR initializes the click listener every time the screen is created.

Screenshots

Before After

Ignore the error after updating at the end. That is a different issue with updating apps from F-Droid store. Emulator has old version of App Lounge without the fix.

In the new App Lounge version, apps from other stores are updateable.

Ignore it for this issue.

Technical details

Bind the Update All click listener during view creation so the button keeps working after the fragment view is recreated. This keeps the existing update action intact without tying listener setup to source-change detection.

Tests

Issues

https://gitlab.e.foundation/e/os/backlog/-/work_items/4242

10 commandments of code review

👪 ❤️ code review guidelines

Edited by Fahim M. Choudhury

Merge request reports

Loading