Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

fix: put exception at the right place in Timber calls.

Description

Timber .d, .i .w , .e , ... have a tricky signature when comming from android.util.Log equivalet.

We could sum it up like that:

android.util.Log.e(tag: String, message: String, exception: Throwable? = null)

Timber.e(exception: Throwable? = null, message: String, messageFormatParams: varargs Any)

So quick translation from Log.e to Timber.e end in Timber.e("message", exception). As exception is a subclass of Any, the compiler doesn't complain, but the log of the exception is swallowed, like here: https://gitlab.e.foundation/e/os/backlog/-/issues/3324#note_712112

08-04 08:21:24.780  9629  6511 E undation.e.apps: Updating download Urls failed for com.vlv.aravali.reels exception: null

Issues

Observed while investigating here, but more a chore fix.

https://gitlab.e.foundation/e/os/backlog/-/issues/3324

10 commandments of code review

👪 ❤️ code review guidelines

Merge request reports

Loading